powsybl / powsybl-afs

AFS modules for powsybl
Mozilla Public License 2.0
3 stars 1 forks source link

Springboot based implementation of AFS backend #63

Closed sylvlecl closed 3 years ago

sylvlecl commented 3 years ago

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

Other information:

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

72.9% 72.9% Coverage
1.5% 1.5% Duplication

warning The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11. Read more here

sylvlecl commented 3 years ago

@pl-buiquang @PratheepDev @jonenst : Just added 2 commits, following issues encountered in production:

jonenst commented 3 years ago

Overall very clean code, I like it, good job

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

82.6% 82.6% Coverage
1.9% 1.9% Duplication