powsybl / powsybl-core

A framework to build power system oriented software
https://www.powsybl.org
Mozilla Public License 2.0
126 stars 41 forks source link

CGMES: SynchronousCondensers are not imported #2606

Closed jeandemanged closed 8 months ago

jeandemanged commented 1 year ago

Describe the current behavior

cim:SynchronousMachine-s with type SynchronousMachineKind.condenser are not imported in iIDM

Describe the expected behavior

Synchronous condensers should be imported in iIDM

Describe the steps

Environment

powsybl-core:5.2.1

Relevant Log Output

No response

Extra Information

It seems that the SPARQL query for synchronous machines assumes that a GeneratingUnit is always present for SynchronousMachines, but this isn't true for condensers - hence query is missing the condensers. cim:RotatingMachine.GeneratingUnit should be considered optional in query, or another dedicated query should be made for condensers.

zamarrenolm commented 1 year ago

I think it will be clearer if we make a specific separate query for synchronous machines than can only be "condensers". For the rest of types (generator, motor and its combinations) we should always have an associated generating unit.