powsybl / powsybl-core

A framework to build power system oriented software
https://www.powsybl.org
Mozilla Public License 2.0
124 stars 40 forks source link

Add historical versions of voltageRegulation xsd for compatibility purposes #3083

Closed olperr1 closed 3 months ago

olperr1 commented 3 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

"Historical" versions of the VoltageRegulation extension are not supported.

What is the new behavior (if this is a feature change)? "Historical" versions of the VoltageRegulation extension are supported.

Does this PR introduce a breaking change or deprecate an API?

If yes, please check if the following requirements are fulfilled

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

The VoltageRegulation extension was historically a private extension which was added to powsybl-core. When it was private, the extension version was increased with each IIDM versions (from 1.0 to 1.12) but versions from 1.1 to 1.12 were identical. When released in powsybl-core these duplicates were not created. But since there is no clean mechanism to match historical versions to the powsybl-core versions, reading serialized network with an historical version is not possible. This PR introduces these historical versions for compatibility.

The default version when serializing has not changed and is still 1.1 for IIDM >= 1.2.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud