powsybl / powsybl-core

A framework to build power system oriented software
https://www.powsybl.org
Mozilla Public License 2.0
124 stars 40 forks source link

Allow to import folders #3086

Closed jonenst closed 3 weeks ago

jonenst commented 3 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem? no

What kind of change does this PR introduce? feature

What is the current behavior? impossible to import all files in a folder, and impossible to import files in a folder that don't have the same basename as the folder

What is the new behavior (if this is a feature change)? possible

Does this PR introduce a breaking change or deprecate an API?

annetill commented 3 months ago

Hi @jonenst, for me it is not a use case. If this feature is for CGMES users, we don't need it. The current design, where we load in triple store, is working fine and the community is used to it. I think that we don't have to create new use cases with datasource, just fix the current ones.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jonenst commented 3 weeks ago

https://github.com/powsybl/powsybl-core/pull/3092 is a more explicit and better choice I think