powsybl / powsybl-core

A framework to build power system oriented software
https://www.powsybl.org
Mozilla Public License 2.0
124 stars 40 forks source link

Create adders from existing objects: ReactiveCapabilityCurve, PhaseTapChanger, RatioTapChanger #3130

Open bc-rte opened 1 month ago

bc-rte commented 1 month ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

This PR introduces adder initialized by copying an existing component.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

If yes, please check if the following requirements are fulfilled

What changes might users need to make in their application due to this PR? (migration steps)

the NetworkImpl::newLine method now has two parametric implementations with one parameter. Users that used network.newLine(null) need to cast null network.newLine((String) null) in order to pass compilation

Other information:

This PR is inspired from previous work there.

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud