powsybl / powsybl-core

A framework to build power system oriented software
https://www.powsybl.org
Mozilla Public License 2.0
123 stars 39 forks source link

Documentation error in two windings transformer model #719

Open annetill opened 5 years ago

annetill commented 5 years ago

Bug.

The documentation of methods getRatedU1(), getRatedU2(), setRatedU1(arg) and setRatedU2(arg) is wrong.

For people, secondary side means lower voltage level. But it does work like this in IIDM model : the secondary side is side 1 if side 1 is lower or side 2 if side 2 is lower.

Change primary by 1 and secondary by 2. Explain in the documentation ".md" how to find the regulation side.

(if a question doesn't apply, you can delete it)

miovd commented 3 years ago

@annetill Has it been resolved?