powsybl / powsybl-diagram-viewer

Other
2 stars 1 forks source link

create-filters-with-draw-control #55

Closed jamal-khey closed 3 months ago

jamal-khey commented 4 months ago

New dependencies: https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-draw/ http://turfjs.org/

informations for the reviewer: Mapbox GL JS itself doesn't have a built-in API specifically for detecting features within an area. However, you can achieve this functionality in a couple of ways:

Turf.js: More suited for pre-processing data or performing more complex spatial analysis. It offers a wider range of geospatial functions.

MapBox gl draw demo itself use truf.js : https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-draw/

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

SlimaneAmar commented 3 months ago

I think it's necessary to disable all interactions with the map during selection

SlimaneAmar commented 3 months ago

The term features is too ambiguous !