search

powsybl / powsybl-diagram

SVG diagrams generation: single-line substation diagrams and network graph diagrams
Mozilla Public License 2.0
70 stars 13 forks source link

Group diagram repositories together with coordinates extensions #334

Open flo-dup opened 2 years ago

flo-dup commented 2 years ago

Do you want to request a feature or report a bug? Refactor

What is the current behavior? Several repositories are somehow related to each other

What is the expected behavior? These repositories could be grouped together in a unique repository

What is the motivation / use case for changing the behavior? Avoid useless multiplication of repos hence releases, group code that works together

flo-dup commented 2 years ago

This unique repository could be named powsybl-diagrams, or @geofjamg suggested keeping the single-line-diagram name.

Indeed, a network-area-diagram could also be seen as a single-line diagram: a diagram with single-line meaning simplification of the three phases/lines into one. Nonetheless, single-line diagram seems to be very commonly used for what is now powsybl-single-line-diagram (diagrams at the voltage level scale). Calling something else single-line diagram might be misleading?

flo-dup commented 2 years ago

What makes sense to take part of the geographical code in that repo, even though there's no link to it yet: it will be used for the network-area-diagram layout, either as an input of the force layout, or for a geographical layout. Maybe also help the powsybl-single-line-diagram substation and zone layout.

What does not make sense in my opinion: it's strange to have such a generic extension in a repo which brings a lot more and whose name does not indicate it would contain it. Indeed one might need the geo data without wanting any diagram feature That would be a specific artifact of the new repo, but still, I think it makes more sense to have it in powsybl-core.

flo-dup commented 2 years ago

About the tree of this new repo, it could be divided in