powsybl / powsybl-diagram

SVG diagrams generation: single-line substation diagrams and network graph diagrams
Mozilla Public License 2.0
72 stars 13 forks source link

Add parameter to disable/enable internal 2wt #594

Closed flo-dup closed 5 months ago

flo-dup commented 5 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem? No

What kind of change does this PR introduce? Bug fix / feature

What is the current behavior? Internal two-winding transformers and phase-shift transformers are added in VoltageLevelGraph as EquipmentNodes, hence are withing an InternCell or ExternCell.

What is the new behavior (if this is a feature change)? Internal two-winding transformers and phase-shift transformers are added in VoltageLevelGraph as FeederNodes, but can be later replaced by EquipmentNodes with VoltageLevelLayoutFactoryParameter::setSubstituteInternalMiddle2wtByEquipmentNodes`. This parameter is true by default.

Other information: NetworkGraphBuilder::handleConnectedComponents (together with child method NetworkGraphBuilder::ensureOneBusInConnectedComponent) needed to move to GraphRefiner in order not to interfere with this feature

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud