powsybl / powsybl-diagram

SVG diagrams generation: single-line substation diagrams and network graph diagrams
Mozilla Public License 2.0
72 stars 13 forks source link

Fix extern cells on two (or more) subsections #597

Closed flo-dup closed 5 months ago

flo-dup commented 5 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem? No

What kind of change does this PR introduce? Bug fix

What is the current behavior? Extern cell on two subsections is detected and its rootBlock replaced by UndefinedBlock

What is the new behavior (if this is a feature change)? Extern cell on two subsections is detected and is cut into pieces in order to have

Does this PR introduce a breaking change or deprecate an API?

Other information: Due to the changes involved, some side-effects appeared which needed the following change/fix: The spanning of crossover intern cells now corresponds to the effective width and not only to a left part containing all equipments; this leads to equipments to be centred on the horizontal (body) part.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud