powsybl / powsybl-dynawo

Dynawo integration in powsybl
Mozilla Public License 2.0
3 stars 0 forks source link

Separate pure dynamic Models from dynamic with static reference Models #113

Closed flo-dup closed 1 year ago

flo-dup commented 2 years ago

Do you want to request a feature or report a bug? Feature

What is the current behavior? Pure dynamic Models and dynamic with static reference Models inherits from the same BlackBoxModel, but

What is the expected behavior? Having two separate Classes:

What is the motivation / use case for changing the behavior? Clear separation of what is purely dynamic from what is linked to static equipment

flo-dup commented 1 year ago

After working on the topic in #136, we decided not to separate in two classes non-static and static refererenced models. We kept the logic which is behind dynawo by only separating BlackBoxModels from the default models, also called Network models, which are created if no mapping is defined on some equipments. Closing this issue as a consequence.