Please check if the PR fulfills these requirements(please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
Does this PR already have an issue describing the problem ?If so, link to this issue using '#XXX' and skip the rest
No
What kind of change does this PR introduce?(Bug fix, feature, docs update, ...)
Bug fix (fix compilation with C++-17 compliant compilers)
What is the current behavior?(You can also link to an open issue here)
With C++-17 and newer versions, stdcxx::optional = std::optional. With older compilers, stdcxx::optional = boost::optional.
Sometimes, we called stdcxx::optional::get() which is boost-specific => the library does not compile with recents compilers.
What is the new behavior (if this is a feature change)?
Compilation is OK with C++-17 and newer compilers
Does this PR introduce a breaking change or deprecate an API?If yes, check the following:
[ ] The Breaking Change or Deprecated label has been added
[ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)
⚠️ Target branch to be defined ⚠️
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the rest NoWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix (fix compilation with C++-17 compliant compilers)
What is the current behavior? (You can also link to an open issue here) With C++-17 and newer versions,
stdcxx::optional
=std::optional
. With older compilers,stdcxx::optional
=boost::optional
. Sometimes, we calledstdcxx::optional::get()
which is boost-specific => the library does not compile with recents compilers.What is the new behavior (if this is a feature change)? Compilation is OK with C++-17 and newer compilers
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)