powsybl / powsybl-open-loadflow

An open source loadflow based on PowSyBl
Mozilla Public License 2.0
45 stars 7 forks source link

Use an existing threshold for filtering senstivity of injection over voltage and voltage over injection #1047

Closed vidaldid-rte closed 3 months ago

vidaldid-rte commented 3 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem? No

What kind of change does this PR introduce? New sensitivities added in https://github.com/powsybl/powsybl-open-loadflow/pull/992 and https://github.com/powsybl/powsybl-open-loadflow/pull/987 are not filtered. This PR reuses the existing threshold flowVoltageSensitivityValueThreshold to filter them. We consider the other order of magnitude of these sensitivities is similar to other sensitivities using this threshold. (for instance this parameter is used for V to reactive power in a branch).

What is the current behavior? The new sensitivies are not filtered

What is the new behavior (if this is a feature change)? The new sensitivies are filtered with the flowVoltageSensitivityValueThreshold

Does this PR introduce a breaking change or deprecate an API?

If yes, please check if the following requirements are fulfilled

What changes might users need to make in their application due to this PR? (migration steps) Users using the sensitivity BUS_VOLTAGE over BUS_REACTIVE_POWER, or INJECTION_REACTIVE_OVER over BUS_VOLTAGE should be aware that the sensitivities are now filtered by the flowVoltageSensitivityValueThreshold threshold.

Other information:

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud