Area Interchange Control as OuterLoop

powsybl / powsybl-open-loadflow

An open source loadflow based on PowSyBl

Mozilla Public License 2.0

48 stars 7 forks source link

Area Interchange Control as OuterLoop #1055

Closed m-guibert closed 1 month ago

m-guibert commented 4 months ago

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #978

Does this PR introduce a breaking change or deprecate an API?

[x] No

vmouradian commented 2 months ago

https://github.com/powsybl/powsybl-open-loadflow/pull/1055#discussion_r1752188627 you renamed the attribute but not the method, but see earlier comment about context data.
I'm not a big fan of wo, not everyone understands it, and also aggravated because the usual abbreviation is w/o but the slash makes it impossible to use in code. The method and attributes are short so I suggest just Without

fixed in 78188368bd470c602002e0284023d932d6625f9c

vmouradian commented 2 months ago

https://github.com/powsybl/powsybl-open-loadflow/pull/1055#discussion_r1752207287 actually the comment was about totalIterations, not totalDistributedActivePower for which the sum is meaningful

I splitted the report of iterations among areas as for the power in 78188368bd470c602002e0284023d932d6625f9c

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud