powsybl / powsybl-open-loadflow

An open source loadflow based on PowSyBl
Mozilla Public License 2.0
48 stars 7 forks source link

Extract Woodbury engine from DC sensitivity analysis #1064

Closed p-arvy closed 4 months ago

p-arvy commented 4 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

The calculation associated with Woodbury equality in DC sensitivity analysis is extracted into a new class : WoodburyEngine.

What is the current behavior?

The calculations are made in DC sensitivity analysis.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

If yes, please check if the following requirements are fulfilled

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

jeandemanged commented 4 months ago

Nice work. All tests passing, including our internal cucumber tests. Maybe need a check from @jeandemanged because we create a new engine.

will have a look by the end of the day

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud