powsybl / powsybl-open-loadflow

An open source loadflow based on PowSyBl
Mozilla Public License 2.0
45 stars 7 forks source link

Add category keys to Parameters #1071

Closed annetill closed 4 weeks ago

annetill commented 2 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

Some category keys are added:

Some keys are missing for automaton systems, secondary voltage control, AC solver type, load model, line per unit mode, asymmetrical calculations, extra reported features, debug directory, min and max realistic voltages, voltage init override

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

If yes, please check if the following requirements are fulfilled

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jeandemanged commented 1 month ago

very nice! some suggestions:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

geofjamg commented 1 month ago

very nice! some suggestions:

  • dc move from category DC to Solver: then we can see in one place if it is DC, NR, NK
  • PerUnit category: I would remove this category and merge it in Model (only linePerUnitMode)
  • reportedFeatures, I would create a new Reporting category, this is not debug.
  • Maybe move the NewtonRaphson params related to state vector scaling in a dedicated category NewtonRaphsonStateVectorScaling (5 parameters), all other parameters remaining in NewtonRaphson would then be related to stopping criteria.

Done for perunit et reportedFeatures.

annetill commented 1 month ago

Looks good!