Closed annetill closed 4 weeks ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
very nice! some suggestions:
dc
move from category DC
to Solver
: then we can see in one place if it is DC, NR, NKPerUnit
category: I would remove this category and merge it in Model
(only linePerUnitMode
)reportedFeatures
, I would create a new Reporting
category, this is not debug.NewtonRaphson
params related to state vector scaling in a dedicated category NewtonRaphsonStateVectorScaling
(5 parameters), all other parameters remaining in NewtonRaphson
would then be related to stopping criteria.Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
99.1% Coverage on New Code
0.0% Duplication on New Code
very nice! some suggestions:
dc
move from categoryDC
toSolver
: then we can see in one place if it is DC, NR, NKPerUnit
category: I would remove this category and merge it inModel
(onlylinePerUnitMode
)reportedFeatures
, I would create a newReporting
category, this is not debug.- Maybe move the
NewtonRaphson
params related to state vector scaling in a dedicated categoryNewtonRaphsonStateVectorScaling
(5 parameters), all other parameters remaining inNewtonRaphson
would then be related to stopping criteria.
Done for perunit et reportedFeatures.
Looks good!
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Some category keys are added:
Some keys are missing for automaton systems, secondary voltage control, AC solver type, load model, line per unit mode, asymmetrical calculations, extra reported features, debug directory, min and max realistic voltages, voltage init override
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: