powsybl / powsybl-open-loadflow

An open source loadflow based on PowSyBl
Mozilla Public License 2.0
45 stars 7 forks source link

Support multiple generators connected to same bus controlling voltage of a different bus #552

Open geofjamg opened 2 years ago

geofjamg commented 2 years ago

(if a question doesn't apply, you can delete it)

geofjamg commented 2 years ago

@annetill after thinking again and prototyping the proposed solution (not working...) I am wondering if the real and clean solution is to move controller from LfBus to LfGenerator. So the VoltageControl class will reference LFGenerators as controllers. voltageControlEnabled will move to LfGenerator too. It will kind of complexify some part of the code but it will be probably cleaner as controller are LfGenerator and not LfBus (On LfBus it is an aggregated view). And this is exactly what we did for ShuntVoltageControl where controllers are LfShunt and not LfBus.

annetill commented 8 months ago

Can I close this issue?