Elementary action new json

powsybl / powsybl-open-rao

A toolbox based on powsybl framework dedicated to power systems coordinated capacity calculation and security analysis projects

Mozilla Public License 2.0

15 stars 6 forks source link

Elementary action new json #1034

Closed pjeanmarie closed 1 month ago

pjeanmarie commented 3 months ago

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

[ ] Yes
[ ] No

If yes, please check if the following requirements are fulfilled

[ ] The Breaking Change or Deprecated label has been added
[ ] The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

pjeanmarie commented 3 months ago

Don't merge before https://github.com/powsybl/powsybl-open-rao/pull/920

pjeanmarie commented 2 months ago

First review. Also if we do not bump version of crac now when will we be doing it ? Usually PR that break compatibility also bump version of json in other powsybl project.

I did not increase the crac version since the 2.4 is not yet released and so to not increase number on unreleased version, the 2.4 will contains multiple changes included this one, the TwoSides one and at least one other. (@pet-mit )

obrix commented 2 months ago

@pjeanmarie Also I saw that you kept the old deserializer, and added new deserializer for the new actions. Because the format is not so different in terms of data, maybe we can use only the new deserializer even for retrocompatibility, like it is usually done in powsybl-core ?

pjeanmarie commented 2 months ago

First review. Also if we do not bump version of crac now when will we be doing it ? Usually PR that break compatibility also bump version of json in other powsybl project.

I did not increase the crac version since the 2.4 is not yet released and so to not increase number on unreleased version, the 2.4 will contains multiple changes included this one, the TwoSides one and at least one other. (@pet-mit )

@obrix @pet-mit Since crac 2.4 version was released with Rao v6.0.0, I will create new version 2.5.

pjeanmarie commented 2 months ago

Also please update the documentation

done

pjeanmarie commented 2 months ago

@pjeanmarie Also I saw that you kept the old deserializer, and added new deserializer for the new actions. Because the format is not so different in terms of data, maybe we can use only the new deserializer even for retrocompatibility, like it is usually done in powsybl-core ?

As discussed, we can have now many deserializer (different action type) where we had only one previously and the format is a bit different so not easy code factorisation here.