powsybl / powsybl-open-rao

A toolbox based on powsybl framework dedicated to power systems coordinated capacity calculation and security analysis projects
Mozilla Public License 2.0
15 stars 6 forks source link

Fix hvdc ra inverted #1036

Closed danielthirion closed 3 months ago

danielthirion commented 3 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Bug fix : the convention on which to invert direction of HVDC RA in the Crac Creator was wrong. As explained in the ENTSOE documentation (https://eepublicdownloads.entsoe.eu/clean-documents/EDI/Library/crac/CRAC_implementation_guide_v2r3.pdf L332-333)

In_Domain.mRID: the area of the related oriented border study where the energy flows into. Out_Domain.mRID: the area of the related oriented border study where the energy comes from.

What is the current behavior?

Direction of HVDC is inverted when compared to CVG results. CORESO raised the issue in a ticket.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

If yes, please check if the following requirements are fulfilled

What changes might users need to make in their application due to this PR? (migration steps)

Other information: