Modify default scaling values in AMPL

p-arvy commented 5 months ago

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

[ ] Yes
[ ] No

If yes, please check if the following requirements are fulfilled

[ ] The Breaking Change or Deprecated label has been added
[ ] The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

p-arvy commented 4 months ago

Hello @So-Fras , the default scaling value for transformers variables is different between AMPL (1e-1) and Java (1e-3). This is the case for not forcing the scaling of a user who only wants to run the AMPL code (not from the OpenReac Java interface).

I think it's more appropriate to put the default value of the java interface in the documentation, but I've added a sentence to indicate that the values can be different. Thank you for the comment!

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

powsybl / powsybl-optimizer

Modify default scaling values in AMPL #72

Quality Gate passed