Closed EtienneLt closed 5 months ago
Did you check that all attributes that are now accessible are correctly per-united? For example target_v for transformer 2 and 3, shunt ? Also all target p and q (hvdc lines etc ) ?
I will add some tests
Did you check that all attributes that are now accessible are correctly per-united? For example target_v for transformer 2 and 3, shunt ? Also all target p and q (hvdc lines etc ) ?
well all targetv for transformer and target p ans q for hvdc are default attributes so they were already perunit I added the non default attributes for generators and vsc stations (max_q_at_p, ....)
update_ratio_tap_changers is missing
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: