powsybl / pypowsybl

A PowSyBl and Python integration based on GraalVM native image
Mozilla Public License 2.0
52 stars 10 forks source link

Add support of dc_power_factor Load Flow Parameter #756

Closed jeandemanged closed 3 weeks ago

jeandemanged commented 1 month ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

PyPowSyBl does not have powsybl-core's dcPowerFactor load flow parameter (https://github.com/powsybl/powsybl-core/pull/2473)

What is the new behavior (if this is a feature change)? Added dc_power_factor load flow parameter

Does this PR introduce a breaking change or deprecate an API?

Other information:

jeandemanged commented 1 month ago

@EtienneLt @geofjamg @obrix help :(

this sounded like an easy feature, but I cannot understand what is going on in load flow validation, why/where a zero power factor shows up and causes an exception ... ( while LoadFlow and SecurityAnalysis are ok ...)

=========================== short test summary info ============================
FAILED test_loadflow.py::test_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_twt_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_all - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_not_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_wrong_regulated_bus_id - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
jeandemanged commented 3 weeks ago

@EtienneLt @geofjamg @obrix help :(

this sounded like an easy feature, but I cannot understand what is going on in load flow validation, why/where a zero power factor shows up and causes an exception ... ( while LoadFlow and SecurityAnalysis are ok ...)

=========================== short test summary info ============================
FAILED test_loadflow.py::test_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_twt_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_all - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_not_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_wrong_regulated_bus_id - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0

there was a bug in LoadFlowValidationParameters code, fix: 13e693618dff3f3fff2efb63731996281997ded6