poxu / runmpv

Runner, which allows to have only one mpv instance on Windows and Linux
6 stars 0 forks source link

Rethink RunMpvProperties#video setting or remove it from settings #40

Open poxu opened 2 years ago

poxu commented 2 years ago

RunMpvProperties#video contains full path to currently launched video file. This is different for each launch and it's ok, because runmpv quits right after video starts. But if runmpv runs in background, RunMpvProperties#video will keep that first video path, because subsequent runmpv launches will exit after video is started and let first instance manage mpv instance.

One solution is to remove video from RunMpvProperties and make it a local variable. After all it's only used as a local variable now. Another way is change the way runmpv works. Maybe old runmpv instance should quit after new runmpv instance is started to refresh setttings from command line and runmpv.properties .