search

pozil / auto-assign-issue

GitHub Action that auto-assigns issues or PRs to one or more users
Creative Commons Zero v1.0 Universal
53 stars 32 forks source link

Add support for assigning pull requests #28

Closed fvictorio closed 2 years ago

fvictorio commented 2 years ago

Hi, thanks for creating this action, it's been really useful for us so far!

Something we want to do is to use it to auto-assign PRs from external contributors. Since GitHub treats PRs as issues, only a minor change is needed to allow this action to support them.

fvictorio commented 2 years ago

Btw, I tested it in a test repository and it worked fine: https://github.com/fvictorio/test-repo/runs/5156612622

codecov[bot] commented 2 years ago

Codecov Report

Merging #28 (653286a) into v1 (8371ced) will increase coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v1      #28      +/-   ##
==========================================
+ Coverage   92.15%   92.30%   +0.15%     
==========================================
  Files           1        1              
  Lines          51       52       +1     
  Branches       12       13       +1     
==========================================
+ Hits           47       48       +1     
  Misses          4        4
Impacted Files Coverage Δ
src/action.js 92.30% <100.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2449673...653286a. Read the comment docs.

pozil commented 2 years ago

Thanks for the PR @fvictorio, this is a great idea, I hadn't realized it would be so easy to make this work with PRs. I'll merge this but I'll keep the original action name and update the readme to prevent breaking changes.

fvictorio commented 2 years ago

For the record: this doesn't work if GitHub actions are not run by default when an external contributor opens a PR :disappointed: I think that's the default behavior and the right behavior (at least if you have secrets in your actions). I don't even know if that can be changed.