Closed calumy closed 2 years ago
Merging #66 (35b2223) into v1 (8bb90b9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## v1 #66 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 1 1
Lines 104 104
Branches 30 30
=======================================
Hits 87 87
Misses 17 17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @CalumY, thanks for the contribution. You're right, the update to lockfile v2 is overdue however, I'll push it myself for security reasons as I cannot review that many changes.
Regarding typescript, I want to avoid including it in the dependencies for as long as possible because we don't need it in the current toolchain and I don't want the extra burden of updating ts versions.
This PR updates the
package-lock.json
file to version 2 as this was highlighted during the "Install npm dependencies" stage of a CI run. This should speed up CI runs when the cache is not available, for example when running using theworkflow_dispatch
trigger, as the new lock file will not need to be generate before the installation begins.Typescript was also added to
node_modules
as it a requirement for a requirement foreslint-plugin-jest
. As this is a dev dependency, I'm not sure if it should be included in the repo. Please let me know if you would like this PR to be updated to remove it (and the other dev dependencies).