search

pozil / pub-sub-api-node-client

A node client for the Salesforce Pub/Sub API
Creative Commons Zero v1.0 Universal
70 stars 37 forks source link

fix: optional and required parameter order in TS #35

Closed oleksii-donoha closed 4 months ago

oleksii-donoha commented 4 months ago

Hi, me again. I remembered why we had that issue with the numRequested and the replayId order. Currently, TS compile fails with: A required parameter cannot follow an optional parameter, which cannot be suppressed. So I've made it so the type description for numRequested doesn't list it as optional so it compiles into a valid .d.ts file. This doesn't change the order or arguments, so it shouldn't break anything.

pozil commented 4 months ago

Thanks for the fix. I'll admit that I'm not using the TS version so I didn't see the issue earlier.