search

pozil / sfdc-ui-lookup-lwc

Salesforce Lookup Component built with Lightning Web Components.
Apache License 2.0
578 stars 223 forks source link

Pclookup keyDown scroll navigation focus fix #159

Closed JYChuah01 closed 1 month ago

JYChuah01 commented 1 month ago

Hi all,

I found an issue related to the list with more than 5 items and scroll-after-n-items="5". Currently if I try to navigate with arrow keys UP and DOWN, the selected element changes but it does not scroll the listbox.

I have implemented a fix for the issue and attached a short video demoing it.

Thanks!

Best, Jun Yi

BEFORE FIX:

https://github.com/user-attachments/assets/4e39ffb4-b638-45c8-a72b-638f1bf7c623

AFTER FIX:

https://github.com/user-attachments/assets/91f137de-4588-4cd4-ad95-70189b02f258

pozil commented 1 month ago

Nice! Thanks @JYChuah01 for providing a fix to the issue a clear example. Can you run prettier so that CI passes?

JYChuah01 commented 1 month ago

Nice! Thanks @JYChuah01 for providing a fix to the issue a clear example. Can you run prettier so that CI passes?

Hii @pozil , I have formatted the code with prettier. Thanks for checking it out!

pozil commented 1 month ago

All good. Thanks again for the PR. I'll release a new version right away.