pozil / sfdc-ui-lookup-lwc

Salesforce Lookup Component built with Lightning Web Components.
Apache License 2.0
578 stars 223 forks source link

Mobile friendly version #8

Open harrymendez23 opened 5 years ago

harrymendez23 commented 5 years ago

Can anyone suggest how to update to make the component more mobile friendly? Combo box does work, but isn't great UX on mobile. This isn't an issue per se, I'm just looking for some advice here.

pozil commented 5 years ago

@harrymendez23 I implemented the SLDS blueprint here. The problem is that this component isn't really designed for mobile. It does works but using a lookup on mobile isn't a common/desired UX pattern. You probably want to show another component when rendering on mobile.

harrymendez23 commented 5 years ago

@pozil thanks for the quick response. That's kind of the challenge I'm facing, none of the OOB components, like lightning:inputfield for instance, seem to behave as expected on mobile. I think lightning:inputfield does not work at all. This is area where salesforce continues to fail miserably.

rnendza commented 4 years ago

Great component. Extra points that we can actually style it without getting the middle finger from our friend Mr. Shadow DOM. What a concept. :)

Thanks for sharing!

Any issues you see with this and filtering through.. potentially 10 or 20k Account records searching by name?

pozil commented 4 years ago

@rnendza I'm glad you like it.

There shouldn't be issue for filtering on large data sets, the client code is optimized for that. You'll just have to pay extra attention to your Apex filtering logic.

rnendza commented 4 years ago

Thanks for the feedback! Reqs on this were dropped for now but I might just play with it for more own knowledge for a future additional to the toolbox. The hardest time I have with this stuff is branching between desktop / mobile as it's gotten to the point where it's pretty much 2 separate code bases unfortunately.

On Tue, Sep 24, 2019 at 2:50 AM Philippe Ozil notifications@github.com wrote:

@rnendza https://github.com/rnendza I'm glad you like it.

There shouldn't be issue for filtering on large data sets, the client code is optimized for that. You'll just have to pay extra attention to your Apex filtering logic.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pozil/sfdc-ui-lookup-lwc/issues/8?email_source=notifications&email_token=AASL6EQVANZLEWVBZZMYFXTQLHBFJA5CNFSM4IYK35YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NN4WY#issuecomment-534437467, or mute the thread https://github.com/notifications/unsubscribe-auth/AASL6EWBZQXXUM26LFERA6DQLHBFJANCNFSM4IYK35YA .

rnendza commented 4 years ago

Thank you.. nice clean component btw.. Probably the best that I've seen. Funny thing is. i just noticed the winter 2020 native lookups (not using a custom component) on salesforce1 / salesforce mobile (whatever it's branded as these days) seem different unless I'm crazy.. more like a picklist which essentially appears as native model with a search input. and search results.

I might try to customize this by adding lookup filter recognition with it. .(seems to be impossible to get that info via the Ui Api or apex describes unfortunately so not gonna be easy)

pozil commented 10 months ago

[!IMPORTANT] While this lookup component won't be ported over to mobile, the Winter '24 release introduces a new Lightning base component that is similar to this lookup component and that works on mobile: lightning-record-picker (release announcement). Note that there are some functionality gaps between the two components. See this readme for a comparison of the two component.