search

ppadovani / KibanaNestedSupportPlugin

A plugin for Kibana 5.5 and beyond that adds support for nested field search and aggregation.
https://ppadovani.github.io/knql_plugin/overview/
Apache License 2.0
79 stars 7 forks source link

Kibana 5.4.0 version Support #22

Closed hosnibenslama closed 6 years ago

ppadovani commented 6 years ago

I'll work on a port this weekend.

hosnibenslama commented 6 years ago

@ppadovani could you make a plugin for that version Thanks in advance

ppadovani commented 6 years ago

I'm splitting my time between 5.4 and 6.0 versions. I have a small blocker I need to figure out for 5.4. If I can get past it, I should be able to finish it pretty quickly.

hosnibenslama commented 6 years ago

Okay thanks 👍

ppadovani commented 6 years ago

Got past a blocker this morning, I should be able to make quick work on the remainder of the port over the next few days. I expect to release this version this weekend.

ppadovani commented 6 years ago

Ran into another blocker. I am unable to override some of the factory classes that I need to, in order to inject my code. The pattern I'm using works fine in 5.5+-6.x so I'm going to have to find a different way to handle 5.4.

hosnibenslama commented 6 years ago

Please let me me know when you get past that blocker Thanks .

ppadovani commented 6 years ago

I may have found a solution, is this release still needed? If so I will take another stab at it this weekend, please let me know.

ppadovani commented 6 years ago

Too many releases to support, and I don't think I have a way around my blockers.

IdanWo commented 6 years ago

Is the same blocker appears to be in all 5.x versions lower than 5.5? If, for example, kibana 5.3 is more suitable for the plugin, than @hosnibenslama can still use it (with a warning message thrown). Chances for that are pretty low, but I still ask to make sure.

ppadovani commented 6 years ago

There are two main reasons why I will not attempt to back port below 5.5:

  1. I already have too many releases to support and I am only one person. I also do this on the side. See this page for all of the current releases: https://ppadovani.github.io/knql_plugin/installation/

  2. The issue with 5.4 and below is how Kibana loads the javascript. In many cases I have to replace functions on various objects BEFORE they are instantiated. This is just not possible in the previous versions, as that code runs BEFORE mine gets loaded.

Feel free to attempt the port yourself if interested.

IdanWo commented 6 years ago

Thanks for explaining the technical blocker. Kibana 5.4.0 released more than a year ago (May 2017, to be exact). It's completly understood why supporting it isn't top priority at all, espcially when more than 7 awesome releases (5.5,5.6, 6.0, 6.1, 6.2, 6.3, 6.4) already went out (and keep coming).