search

ppadovani / KibanaNestedSupportPlugin

A plugin for Kibana 5.5 and beyond that adds support for nested field search and aggregation.
https://ppadovani.github.io/knql_plugin/overview/
Apache License 2.0
79 stars 7 forks source link

Percentile aggregations don't work on nested fields #63

Closed erkserkserks closed 6 years ago

erkserkserks commented 6 years ago

Plugin version: 6.2.2-1.0.4 and 5.6.6-1.0.2

Kibana version: 6.2.2 and 5.6.6

Plugins installed: KNQL only

Description of the problem including expected versus actual behavior: Percentile aggregations don't work on nested fields. I have also encountered this issue with the standard deviation, median, and percentile ranks aggregations.

The test data was generated using scripts/nested-support/genData.py Both Kibana 5.6.6 and 6.2.2 have the same bug.

This does the right thing (Non-nested field): expected

This does the wrong thing (Nested field): actual

We seem to be getting a valid elasticsearch response with nested field, but the response is not rendered properly actual response

Errors in browser console (if relevant): There wasn't anything interesting in the console before these rendering errors. console log

ppadovani commented 6 years ago

Thanks for the report. I won't be able to look at this until late this coming weekend. At first glance, it looks like I'm missing some functionality on the response processing. I don't think it will be difficult to get working.

ppadovani commented 6 years ago

Ok.. tracked down the percentiles one... the others should be easy enough to track down and fix. I won't have time to finish this until the weekend.

erkserkserks commented 6 years ago

No worries! Thanks for taking a look :)

ppadovani commented 6 years ago

Ok.. I have these fixed locally... I'm going to track down the other two issues, then I'll cut a release.

ppadovani commented 6 years ago

Fixed in 6.2.2, 6.2.3, 6.2.4

Will begin back porting tomorrow.

ppadovani commented 6 years ago

Fixed in 6.2.1

ppadovani commented 6 years ago

Back ported to all supported 6.X+++ releases

ppadovani commented 6 years ago

Ported to: 5.6.7, 5.6.8 and 5.6.9

ppadovani commented 6 years ago

done