ppalucha / ksar2

Fork of ksar - a sar grapher
Other
29 stars 15 forks source link

Missing colors #8

Closed ams-tschoening closed 6 years ago

ams-tschoening commented 7 years ago

This branch deals with the following warnings:

WARN: color not found for tag %irq WARN: color not found for tag %soft WARN: color not found for tag %guest

ams-tschoening commented 7 years ago

It seems like "someone" is allocating reasonable and unique colors automatically in case they are missing, because while the above warnings got printed, everything seemed to work and different colors were used for different values. So it might be an option to not provide any colors anymore in Config.xml, but remove all of those in favour to let that "someone" deal with colors automatically.

Managing those colors seems to be a lot of unnecessary work. I still get lots of warnings for my files:

WARN: color not found for tag avgrq-sz WARN: color not found for tag avgqu-sz WARN: color not found for tag rd_sec/s WARN: color not found for tag wr_sec/s WARN: color not found for tag await WARN: color not found for tag svctm WARN: color not found for tag %util WARN: color not found for tag %hugused WARN: color not found for tag kbhugfree WARN: color not found for tag kbhugused WARN: color not found for tag %memused WARN: color not found for tag %swpused WARN: color not found for tag %commit WARN: color not found for tag kbmemfree WARN: color not found for tag kbmemused WARN: color not found for tag kbmemshrd WARN: color not found for tag kbbuffers WARN: color not found for tag kbcached WARN: color not found for tag kbcommit WARN: color not found for tag kbswpfree WARN: color not found for tag kbswpused WARN: color not found for tag kbswpcad WARN: color not found for tag %swpcad WARN: color not found for tag blocked WARN: color not found for tag read/s WARN: color not found for tag write/s WARN: color not found for tag access/s WARN: color not found for tag getatt/s WARN: color not found for tag call/s WARN: color not found for tag retrans/s WARN: color not found for tag packet/s WARN: color not found for tag udp/s WARN: color not found for tag tcp/s WARN: color not found for tag hit/s WARN: color not found for tag miss/s WARN: color not found for tag call/s WARN: color not found for tag badcalls/s WARN: color not found for tag sread/s WARN: color not found for tag swrite/s WARN: color not found for tag saccess/s WARN: color not found for tag sgetatt/s WARN: color not found for tag frmpg/s WARN: color not found for tag shmpg/s WARN: color not found for tag bufpg/s WARN: color not found for tag campg/s WARN: color not found for tag fault/s WARN: color not found for tag majflt/s WARN: color not found for tag pgfree/s WARN: color not found for tag pgscank/s WARN: color not found for tag pgscand/s WARN: color not found for tag pgsteal/s WARN: color not found for tag activepg WARN: color not found for tag inadtypg WARN: color not found for tag inaclnpg WARN: color not found for tag inatarpg WARN: color not found for tag pgpgin/s WARN: color not found for tag pgpgout/s WARN: color not found for tag vmeff WARN: color not found for tag ip-frag WARN: color not found for tag tcp-tw WARN: color not found for tag totsck WARN: color not found for tag tcpsck WARN: color not found for tag udpsck WARN: color not found for tag rawsck WARN: color not found for tag pswpin/s WARN: color not found for tag pswpout/s

ams-tschoening commented 6 years ago

What does "approving" without merging this PR means?