search

ppalucha / ksar2

Fork of ksar - a sar grapher
Other
29 stars 15 forks source link

Manage colors automatically #9

Closed ams-tschoening closed 6 years ago

ams-tschoening commented 7 years ago

I suggest removing color definitions in the Config.xml by default, because it looks like ksar is able to handle missing ones automatically. This should remove a lot of maintenance time for increasing data in sar files in future. This is related to PR #8, only one of both approaches is needed.

https://github.com/ppalucha/ksar2/pull/8

ppalucha commented 6 years ago

I'm against this feature, as we want to keep colors for specific graphs "stable" - for example we expect CPU usage to be green as people are used to it. Automatic assignment would make colors changed.

ams-tschoening commented 6 years ago

So how do you want to deal with all the warnings about missing colors I already mentioned in a comment to PR #8? Simply ignoring them means that they will get random colors every time. Have a look at the following image, one can't distinguish %usr and %guest anymore:

clipboard01

ppalucha commented 6 years ago

I wrote I don't want to break historical colors. I don't care too much about colors for newly added data - if they conflict with existing colors, we can always set them manually.