Attempt to start Logic for user running Linux blocks forever

ppannuto / python-saleae

Python library to control a Saleae Logic Analyzer

Apache License 2.0

124 stars 55 forks source link

Attempt to start Logic for user running Linux blocks forever #38

Closed johnthagen closed 6 years ago

johnthagen commented 6 years ago

See:

https://github.com/ppannuto/python-saleae/blob/master/saleae/saleae.py#L89

elif platform.system() == 'Linux':
    ret = os.system('Logic')

os.system will block until Logic closes, effectively making this ineffective to the user, because the Python code doesn't continue on and try to connect to Logic over the socket.