Closed jkesanen closed 6 years ago
Looks good! Thanks for the addition.
As this only works with some of the devices, could you add a runtime check that the method is being called for a valid Saleae, and give a nice warning otherwise? Check out set_active_channels
as an example. You can also add the #doctest:+SKIP
from that, as test infrastructure doesn't have a great way to handle having the "right" soft Saleae active currently.
Thanks for feedback!
I did the changes you suggested and tested them with real Logic Pro 16 and the virtual Logic 4.
Thanks for merging in. And thanks for the project. Been very helpful for me,
Needed to configure digital I/O threshold voltage, but it wasn't implemented. The functionality was available in SaleaeSocketAPI. Added methods for querying available and current voltages, and setting the voltage.
Tested with Python versions 2.7.14 and 3.6.4.
Tested with Saleae Logic 16 and Saleae Logic Pro 16.