search

ppannuto / python-saleae

Python library to control a Saleae Logic Analyzer
Apache License 2.0
124 stars 55 forks source link

Implement get_sample_rate #53

Closed wcampbell0x2a closed 3 years ago

wcampbell0x2a commented 4 years ago

https://github.com/ppannuto/python-saleae/blob/f005d9acbd903b4e9720a287f131c7da546e8f5e/saleae/saleae.py#L424

This is no longer true, per the document from Saleae: https://github.com/saleae/SaleaeSocketApi/blob/master/Doc/Logic%20Socket%20API%20Users%20Guide.md#get-selected-collection-sample-rate

ppannuto commented 4 years ago

Neat! Happy to take a PR that adds the new interface -- thanks!

sophiekovalevsky commented 3 years ago

@ppannuto first thing first, what a great tool that you have built :D thanks so much for all the great effort.

In a few seconds I will create a PR that aims to fix this issue.