Added optional args to forward to Logic

ppannuto / python-saleae

Python library to control a Saleae Logic Analyzer

Apache License 2.0

124 stars 55 forks source link

Added optional args to forward to Logic #58

Closed Marcus10110 closed 4 years ago

Marcus10110 commented 4 years ago

This allows the user to pass command line arguments to the logic executable, both through the Saleae constructor and through the launch_logic function.

useful arguments: -disablepopups disables blocking popups in the application, like the "could not keep up" error. -uploaderrors automatically accept and close the "upload error reports" dialog, if restarting the application after a crash.

example:

import saleae
s = saleae.Saleae('127.0.0.1', 10429, False, '-disablepopups -uploaderrors')
# or
Saleae.launch_logic(args='-disablepopups -uploaderrors')

Tested on MacOS!

TODO:

[x] Test on Windows
[x] Test on Linux

ppannuto commented 4 years ago

Cool new feature!

Travis runs on Linux, so it would be relatively easy to check off the 'Tested on Linux' box there. It looks like both of these are reasonable flags to enable for CI anyway (even if they are unlikely to be relevant without a physical device).

Marcus10110 commented 4 years ago

@ppannuto all set! There was a small snag on windows that's fixed now, and I did manual testing on Linux too, although only with Saleae.launch_logic since the logic path can't be passed through the constructor.

Also not sure how you like to take PRs, but I've assigned you as a reviewer. This should be ready to merge now.

ppannuto commented 4 years ago

Oops, should've read the rest of the github notifications first!

This looks good to me.

Same question: is there more stuff coming, or does it make sense to kick out a release with this and #59?