Let set_triggers_... raise on incorrect triggers - Githubissues

ppannuto / python-saleae

Python library to control a Saleae Logic Analyzer

Apache License 2.0

124 stars 55 forks source link

Let set_triggers_... raise on incorrect triggers #77

Closed maltekliemann closed 3 years ago

maltekliemann commented 3 years ago

Until now, set_triggers_for_all_channles raised a CommandNAKedError when it's called if too many or too few Trigger.*edge are provided, which leaves the user guessing what went wrong. Now it raises a more verbose ImpossibleSettings.

I'm not sure if this is to your liking, but I got stuck on this for a few hours and thought it might be helpful for other users to provide more feedback.

ppannuto commented 3 years ago

This is great -- I'm all about proactive checks like this. Thanks for the addition!