change `setup_requires` to `install_requires`

ppannuto / python-titlecase

Python library to capitalize strings as specified by the New York Times Manual of Style

MIT License

244 stars 36 forks source link

change `setup_requires` to `install_requires` #57

Closed ppannuto closed 4 years ago

ppannuto commented 4 years ago

Fixes #56.

@iburago, I think it makes sense to just move nose over too? Nothing is really done in setup for this package.

coveralls commented 4 years ago

Coverage remained the same at 85.128% when pulling 84d13b9e6026f51ab5f333c1bf21ddad4402411a on regex-install into cf59b1f2ee85ea4b8926f99928123a1a7eb34526 on master.

igorburago commented 4 years ago

Well, the nose package is only necessary for running tests.py, and is not required for titlecase to function properly otherwise. Hence, I think, we should not list it as a dependency to be automatically installed on the user’s system.

I would put nose under tests_require, instead, leaving install_requires only for regex.

ppannuto commented 4 years ago

Sure, that makes sense; updated.

igorburago commented 4 years ago

Looks good to me now.