search

ppannuto / python-titlecase

Python library to capitalize strings as specified by the New York Times Manual of Style
MIT License
254 stars 38 forks source link

version confusion, 0.13.1 containing newer code compared to 1.1.1 #72

Closed valentijnscholten closed 3 years ago

valentijnscholten commented 4 years ago

I was waiting for #60 to become released to get rid of all the log messages. Looking at that PR it seems merged and released. However we are on the latest release 1.1.1 and the issue is still there.

Looking at the commit history it looks like 0.13.1 contains the fix and was released after 1.1.1?

We're using dependabot and renovate to stay up-to-date and they are not reporting when 0.13.1 was released, nor will they alert us on any 0.x release as 1.1.1 is newer according to semver (or a different major version alltogether).

What is the recommended version to run?

valentijnscholten commented 4 years ago

after reading some more I see that 1.0 dropped python2 support and 1.1.1 should be identical to 0.13.1. but it isn't :-) The changes from #60 are missing in 1.1.1: https://github.com/ppannuto/python-titlecase/blob/v1.1.1/titlecase/__init__.py

ppannuto commented 4 years ago

60 is not in any released version, there are number of patches in main that have not yet been pushed out to any release:

image

I'd deferred a release a @iburago mentioned there was some more stuff to come; though perhaps the time has come to just do a release.

brunobg commented 3 years ago

Yes, +1 for a new release.

ppannuto commented 3 years ago

Pushed v2.0 to PyPI