search

ppat / storm-rabbitmq

A library of tools for interacting with RabbitMQ from Storm.
MIT License
126 stars 77 forks source link

ConfigUtils should have methods to provide default values #16

Closed jnioche closed 10 years ago

jnioche commented 10 years ago

This could be used for ConnectionConfig so that it could rely on those and hence allow the users not to have to specify the default values explicitely

ppat commented 10 years ago

I think the only thing off in your pull request is use of tabs. If you just use spaces instead of tabs and set two spaces for every level of indentation, that should be good.

I don't use Eclipse, but IntelliJ, and I have it set to default formatting that it comes with for Java.

jnioche commented 10 years ago

I fixed the tabs by hand in the second version (b178800), should be good now.