search

ppat / storm-rabbitmq

A library of tools for interacting with RabbitMQ from Storm.
MIT License
126 stars 77 forks source link

RabbitMQBolt addition. #21

Closed bdgould closed 9 years ago

bdgould commented 9 years ago

Moved to latest version of Storm and RabbitMQ amqp-client JARs.

Added a bolt implementation for publishing to RabbitMQ exchanges.

Added an ssl option to the non-uri configuration in the ConnectionConfig class.

drazzib commented 9 years ago

Thanks @bdgould! I've done a quick review and this seems fine for me.

I'll let @ppat further comment.

ppat commented 9 years ago

@bdgould Looks great. Thanks for the pull request.

One of the additions I plan to make to RabbitMQProducer is to allow programmatic (or rather dynamic selection) of exchange name and routing keys based on values in the tuple. I think the configuration of exchange/routing key in question can move to TupleToMessage interface and the implementation can make the decision of whether to base it on incoming tuple data or fixed values.

bdgould commented 9 years ago

Sure thing, will do.