ppazos / cabolabs-ehrserver

Open platform to manage and share standardized clinical data, designed by @ppazos at CaboLabs Health Informatics.
https://cabolabs.com
Apache License 2.0
179 stars 110 forks source link

versionedComposition/index filter by organization fails #913

Closed ppazos closed 6 years ago

ppazos commented 6 years ago

Cannot get property 'data' on null object

https://github.com/ppazos/cabolabs-ehrserver/blob/master/grails-app/views/versionedComposition/index.gsp#L82

versionedCompositionInstance.latestVersion seems to be null

ppazos commented 6 years ago

The problem is caused by having version.uid with the wrong format in the database, it should be UID::SYSTEM_ID::VERSION and we have some that are only UUIDs!

This break the VersionedComposition.getLatestVersion() since it expects to have a :: to match the VC UID with the first part of the VERSION.UID, see https://github.com/ppazos/cabolabs-ehrserver/blob/79d447e6d3dabc8580406e9e2f053df287ec2d47/grails-app/domain/com/cabolabs/ehrserver/openehr/common/change_control/VersionedComposition.groovy#L71

We need to add a format check in the XSD to avoid accepting version uids with the incorrect format.

The XSD update should be reflected in the openEHR-OPT and openEHR-OPT-GUI projects.