search

ppc64le-cloud / docker-ce-build

Apache License 2.0
0 stars 8 forks source link

Use git hashes #170

Closed AshwinHIBM closed 7 months ago

AshwinHIBM commented 8 months ago
  1. We currently use the DOCKER_REF environment variable for mentioning the tag that will be used to checkout Docker CLI and Docker Engine. This pull request decouples these into two new environment variables; DOCKER_CLI and DOCKER_ENGINE which contain the git hashes for the Docker CLI and Docker Engine repositories separately to reduce reliance on tags.
  2. We currently have a single environment variable CONTAINERD_REF which contains the tag to the CONTAINERD repository. This pull request replaces this with two variables, CONTAINERD_TAG (to create directories on the COS buckets for naming these built packages) and CONTAINERD_HASH for actually checking out the correct version of the containerd repository.
clnperez commented 8 months ago

Is a TAG var always a tag [0-9,A-Z,a-z,-,_,.]{1.128}, and a HASH is always a hash (a 12 or 64-character hexadecimal string)? What could REF be? This starts getting a little fuzzy for me where there could be overlap on what each of those mean, and also when some of the new vars don't make it clear which they should be (e.g. DOCKER_CLI).

ppc64le-cloud-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM, clnperez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/docker-ce-build/blob/main/OWNERS)~~ [AshwinHIBM,clnperez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment