search

ppc64le-cloud / docker-ce-build

Apache License 2.0
0 stars 8 forks source link

Upstream CI unit and integration test updates #182

Closed AshwinHIBM closed 6 months ago

AshwinHIBM commented 6 months ago

Reduce the amount of code and avoid doing a direct docker run against moby repository and instead use their Makefile for the tests.

ppc64le-cloud-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/docker-ce-build/blob/main/OWNERS)~~ [AshwinHIBM] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clnperez commented 6 months ago

Are you still working on that rc issue for this one?

AshwinHIBM commented 6 months ago

i see that you're building the dev image for each test suite. is that something we could re-use for the 2nd (whether it be unit or integration that runs 2nd) test suite? maybe keep an env var of the image ref and pass it around? if that's too much of a rework maybe consider it as a followon PR

That's definitely something I prefer. These jobs aren't chained though so an image created during build-dev-image.sh won't be reusable in the test scripts. I can see 3 options:

  1. Chain them.
  2. Remove the build-dev-image script given that we're building the image in the test scripts.
  3. Push the build-dev-image created in build-dev-image.sh to a private registry.