search

ppc64le-cloud / docker-ce-build

Apache License 2.0
0 stars 8 forks source link

Fix Automatic Pushing of Builds to shared COS bucket #90

Closed AshwinHIBM closed 1 year ago

AshwinHIBM commented 1 year ago

Certain distributions have reached end of life and are yet discovered by the code from the upstream repository. This commit helps the code skip through those distributions. This is being done to fix an issue where the packages do not get automatically pushed to the shared COS bucket as the code refuses to copy over any packages if there is any error thrown at any point through the build process.

ppc64le-cloud-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/docker-ce-build/blob/main/OWNERS)~~ [AshwinHIBM] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clnperez commented 1 year ago

is exclusions something that we could configure via the prow job env vars? if we wanted to add a new couple just for one run, for example, but didn't want to submit a PR to edit the file.

AshwinHIBM commented 1 year ago

We should definitely have exclusions separated out from the code. I have moved it to env/env.list and tested.

clnperez commented 1 year ago

in our internal issue, it's stated that this is to fix a problem with pushing built packages? can you add that to the description/summary comment and commit summary? (so it's visible here in the web UI and also in the commit message)

clnperez commented 1 year ago

/lgtm