search

ppc64le-cloud / powervs-utils

Apache License 2.0
0 stars 10 forks source link

Add Chennai region and zones and update SysTypes #15

Closed arshadd-b closed 22 hours ago

arshadd-b commented 1 week ago

This PR adds regions and zones and updates SysTypes Fixes issue https://github.com/ppc64le-cloud/powervs-utils/issues/14

ppc64le-cloud-bot commented 1 week ago

Welcome @arshadd-b! It looks like this is your first PR to ppc64le-cloud/powervs-utils 🎉

mkumatag commented 1 week ago

/cc @dharaneeshvrd @Karthik-K-N

please review and also Chennai DC and also go through this doc - https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-ibm-cloud-reg and see what else is missing.

Prajyot-Parab commented 1 week ago

@arshadd-b Add Chennai DC

zone   -> che01
region -> che
arshadd-b commented 1 week ago

I have noticed new machine Types added in zones, I have added those as well But in some cases like in Zone dal12 having machine types E980, S922and dal10 is having machine types E980, S1022, S922 . Machine Types are different for different zones. How should we handle these cases since we have single entry of zones belonging to same region in map ?

For now we have kept the common machine Types in zones https://github.com/ppc64le-cloud/powervs-utils/blob/main/region.go#L65

dharaneeshvrd commented 1 week ago

Individual zone based machine types would alter the current region map. If we are sure that region map is not directly consumed and only util funcs are consumed, then we can alter the map and util funcs.

Karthik-K-N commented 1 week ago

I dont have much idea on the impact, @hamzy @mjturek could you please take a look.

mkumatag commented 1 week ago

we shouldn't have made public if not required!

Individual zone based machine types would alter the current region map. If we are sure that region map is not directly consumed and only util funcs are consumed, then we can alter the map and util funcs.

arshadd-b commented 2 days ago

I have noticed new machine Types added in zones, I have added those as well But in some cases like in Zone dal12 having machine types E980, S922and dal10 is having machine types E980, S1022, S922 . Machine Types are different for different zones. How should we handle these cases since we have single entry of zones belonging to same region in map ?

For now we have kept the common machine Types in zones https://github.com/ppc64le-cloud/powervs-utils/blob/main/region.go#L65

Have created different issue for this https://github.com/ppc64le-cloud/powervs-utils/issues/16

dharaneeshvrd commented 2 days ago

Overall LGTM! @arshadd-b Please update the commit message with proper details!

arshadd-b commented 2 days ago

Overall LGTM! @arshadd-b Please update the commit message with proper details!

done

ppc64le-cloud-bot commented 22 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arshadd-b, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/powervs-utils/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment