search

ppc64le-cloud / powervs-utils

Apache License 2.0
0 stars 10 forks source link

PowerVS: Add an only IPI regions list #9

Closed hamzy closed 9 months ago

hamzy commented 10 months ago

In order for the IPI installer to be able to use this module, it needs the ability to have the list of regions to only include supported regions.

ppc64le-cloud-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hamzy Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/ppc64le-cloud/powervs-utils/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hamzy commented 10 months ago

/hold

hamzy commented 10 months ago

/hold cancel

hamzy commented 10 months ago

/assign @mkumatag

hamzy commented 9 months ago

I looks like IPI will have to live with updating the same code in two different repos instead of using a module.

mkumatag commented 9 months ago

I looks like IPI will have to live with updating the same code in two different repos instead of using a module.

I don't see any better way, @Karthik-K-N @dharaneeshvrd if you have any better idea for this?

hamzy commented 9 months ago

This PR does provide a way to solve the problem. It also effects the code minimally without altering every API used.

mkumatag commented 9 months ago

This PR does provide a way to solve the problem. It also effects the code minimally without altering every API used.

But I see repeated code there, need find a way to reduce that.

hamzy commented 9 months ago

Hrm, when you force push a new version, you cannot reopen the PR. How weird.