Closed kishen-v closed 2 days ago
cc: @Karthik-K-N.
@kishen-v it will be great if you can divide this PR into two, one for deprecating and another for cleanup..
Working on splitting the PR to contain smaller changes. /hold
@kishen-v can you please rebase this PR?
/hold cancel
@kishen-v lets fix the remaining comments and merge the code
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kishen-v, mkumatag
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Fixes: #496, #609.
Note: The changes are done, a quick round of testing across all sub-commands is complete, barring test.cloud.ibm.com
get:
Works with workspace ID or workspace name/ network ID and network name
delete:
create:
purge:
[x] volumes Purge the powervs volumes
dhcpserver
[x] list Get PowerVS DHCP servers
image
What wasn't tested: Testing in the
test
environment - https://test.cloud.ibm.com/loginAdditional tweaks/changes that are a part of this PR:
pvsadm image upload
- Iterate through the available set of keys until a credential with a binding HMAC key is found, rather than exiting out.