ppc64le-cloud / pvsadm

Tool for managing the IBM Power Systems Virtual Servers
Apache License 2.0
37 stars 32 forks source link

Deprecate bluemix-go and clean-up code. #612

Closed kishen-v closed 2 days ago

kishen-v commented 4 months ago

Fixes: #496, #609.

Note: The changes are done, a quick round of testing across all sub-commands is complete, barring test.cloud.ibm.com

get:
purge:
kishen-v commented 4 months ago

cc: @Karthik-K-N.

mkumatag commented 3 months ago

@kishen-v it will be great if you can divide this PR into two, one for deprecating and another for cleanup..

kishen-v commented 3 months ago

Working on splitting the PR to contain smaller changes. /hold

mkumatag commented 1 month ago

@kishen-v can you please rebase this PR?

kishen-v commented 3 weeks ago

/hold cancel

mkumatag commented 1 week ago

@kishen-v lets fix the remaining comments and merge the code

ppc64le-cloud-bot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/pvsadm/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment