ppc64le-cloud / pvsadm

Tool for managing the IBM Power Systems Virtual Servers
Apache License 2.0
37 stars 36 forks source link

Enhancement: Check if a condition is met before the polling interval has elapsed. #676

Open kishen-v opened 10 hours ago

kishen-v commented 10 hours ago

What happened:

An instant first tick is preferred over long running operations, which may have a particular condition satisfied already. https://github.com/ppc64le-cloud/pvsadm/blob/d2d3bd1406b9b8ce6a647c8d00db6b7bf58ffd67/pkg/utils/utils.go#L59-L71

What you expected to happen: The condition to be checked once when the function is invoked, to cut down on waiting for a condition that may already be achieved.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?: https://stackoverflow.com/questions/32705582/how-to-get-time-tick-to-tick-immediately

Environment:

kishen-v commented 9 hours ago

/good-first-issue

ppc64le-cloud-bot commented 9 hours ago

@kishen-v: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/ppc64le-cloud/pvsadm/issues/676): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aman4433 commented 9 hours ago

/assign