search

ppc64le-cloud / test-infra

Apache License 2.0
6 stars 19 forks source link

Add Guaranteed QoS to prow test pods #393

Closed Rajalakshmi-Girish closed 1 year ago

Rajalakshmi-Girish commented 1 year ago

Looked at the public k8s UT and conformance jobs and they seem to use 4 cpus as the limit. References: K8s UT: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-testing/make-test.yaml#L33 K8s Conformance: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gce-conformance.yaml#L67

Also, it is ~1000mcpu for capi-provider jobs. But our recent changes periodic-capi-provider-ibmcoud-e2e-powervs is failing sometimes even with 2500. Hence have set the limit for these capi jobs to 3000m

For the perf-clusterloader2 jobs, upstream seem to use 2 cpu. I have set it to 3000mcpu to be on the safer side.

ppc64le-cloud-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/ppc64le-cloud/test-infra/blob/master/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ppc64le-cloud-bot commented 1 year ago

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

In response to [this](https://github.com/ppc64le-cloud/test-infra/pull/393): >Looked at the public k8s UT and conformance jobs and they seem to use 4 cpus as the limit. >References: >K8s UT: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-testing/make-test.yaml#L33 >K8s Conformance: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/gce-conformance.yaml#L67 > >Also, it is ~1000mcpu for `capi-provider` jobs. But our recent changes `periodic-capi-provider-ibmcoud-e2e-powervs` is failing sometimes even with 2500. Hence have set the limit for these capi jobs to 3000m > >For the `perf-clusterloader2` jobs, upstream seem to use 2 cpu. I have set it to 3000mcpu to be on the safer side. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.